Support tabindex overriding for Button, MenuButton, ToggleButton, Checkbox, and Anchor #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-akinc
commented
May 15, 2024
|
@msmithNI Will you buddy this for me? |
m-akinc
changed the title
m-akinc
commented
May 15, 2024
msmithNI
requested changes
May 16, 2024
packages/nimble-components/src/button/tests/button.foundation.spec.ts
Outdated
Show resolved
Hide resolved
msmithNI
approved these changes
May 16, 2024
jattasNI
approved these changes
May 17, 2024
rajsite
reviewed
May 20, 2024
rajsite
reviewed
May 20, 2024
rajsite
approved these changes
May 21, 2024
rajsite
reviewed
May 21, 2024
Co-authored-by: Milan Raj <rajsite@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Fixes #2094
👩💻 Implementation
For each of
Button,MenuButton,ToggleButton, 'Checkbox', andAnchor, addedtabindexattribute, updated the template to forward thetabindexvalue, and wrote automated tests. Additionally forButtonandCheckbox, forked template from FAST and copied over the FAST tests.🧪 Testing
Ran tests. Manually tested in Storybook in Chrome and Firefox.
✅ Checklist